-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Refactor entities based on AST parsing logic #18517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b5976c2
to
bc363fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
/ok-to-test sha=b5a0496 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3636215574. |
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/AstServiceCEImpl.java
Show resolved
Hide resolved
Raised a separate bug to track this
Issue 1 and 4 are the ones that need to be looked into. Testsmith link
|
/ok-to-test sha=bab7186 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3639509097. |
/perf-test sha=bab7186 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3648592718. |
/perf-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3649355355. |
/perf-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3655467511. |
With 3 open issues around this which will be handled later -
Moving the status to Done |
/perf-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3657330043. |
/perf-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/3658245000. |
Warning Rate limit exceeded@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 32 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
As a result of this PR, incorrectly refactored references to other entities (widgets, actions, JS objects, JS functions) like when the same string happened to be in a comment, a nested path, a string or any other invalid reference, will now be ignored during refactors. This eliminates another source of possible cyclic dependency errors in Appsmith apps.
Fixes #17047
Fixes #17564
Fixes #17556
Fixes #18493
Fixes #18492
Fixes #18699
Waiting on:
Type of change
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity: